Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(binary): update promtail to version 1.6.0 #26

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

secustor
Copy link
Contributor

As loki 1.6.0 is released so is promtail.
https://github.com/grafana/loki/releases/tag/v1.6.0

@patrickjahns
Copy link
Owner

Thank you for submitting the PR - checking CI the errors are unrelated to your change

[208] File permissions not mentioned

tasks/install.yml:68

Task/Handler: Unpack promtail binaries

[208] File permissions not mentioned

tasks/install.yml:86

Task/Handler: Write config

[208] File permissions not mentioned

tasks/install.yml:95

Task/Handler: Create systemd service unit

ERROR: Lint failed: Command 'set -e

I will fix the linting/role and then we can proceed here

Quick question - did you encounter any configuration changes to the promtail config that would need to be considered for the version bump?

@secustor
Copy link
Contributor Author

We are running this role with an overwritten version right now in our staging environment.
So far we haven't any issues.

The only changes in the configuration I could find are these two point which are documented in the changelogs. These only ad functionality and don't break anything:

https://github.com/grafana/loki/releases/tag/v1.6.0

  • 2060 introduces the Replace stage, which lets you find and replace or remove text inside a log line. Combined with 2422 and 2480, you can now find and replace sensitive data in a log line like a password or email address and replace it with ****, or hash the value to prevent readability, while still being able to trace the value through your logs. Last on the list of pipeline additions,
  • 2496 adds a Drop pipeline stage, which lets you drop log lines based on several criteria options including regex matching content, line length, or the age of the log line. The last two are useful to prevent sending to Loki logs that you know would be rejected based on configured limits in the Loki server.

@patrickjahns patrickjahns added dependencies Pull requests that update a dependency file semver:minor Change leading to a minor level version bump labels Sep 3, 2020
@patrickjahns patrickjahns merged commit f4d4873 into patrickjahns:master Sep 3, 2020
@github-actions github-actions bot mentioned this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file semver:minor Change leading to a minor level version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants