Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated config.expand-env related variable and templating #194

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Updated config.expand-env related variable and templating #194

merged 2 commits into from
Nov 1, 2023

Conversation

azhinu
Copy link
Contributor

@azhinu azhinu commented Sep 18, 2023

Resolved #187.

promtail_config_expand_env variable changed from "false" to False to avoid templating issue.

-config.expand-env={{ "true" if promtail_config_expand_env else "false" }} templating has been simplified, now it's -config.expand-env={{ promtail_config_expand_env | lower }}

@patrickjahns patrickjahns added the bug Something isn't working label Nov 1, 2023
@patrickjahns
Copy link
Owner

Thank you for the fix - will be in the upcoming release

@patrickjahns patrickjahns merged commit dc0227d into patrickjahns:master Nov 1, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promtail_config_expand_env variable is wrong by default
2 participants