Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise privileges of restart handler #15

Merged
merged 1 commit into from
May 26, 2020

Conversation

riptl
Copy link
Contributor

@riptl riptl commented May 26, 2020

The restart handler does not escalate privileges.

I'm seeing this failure on Ubuntu 20.04 LTS.

RUNNING HANDLER [promtail : Restart promtail] ***********************************************************
fatal: [loki-monolith-s-instance]: FAILED! => {"changed": false, "msg": "failure 1 during daemon-reload: Failed to reload daemon: Access denied\n"}

@patrickjahns patrickjahns added the bug Something isn't working label May 26, 2020
@patrickjahns
Copy link
Owner

Thanks - I'll merge it when CI gets green and create a release with the fix included 👍

@patrickjahns patrickjahns merged commit 9476957 into patrickjahns:master May 26, 2020
@github-actions github-actions bot mentioned this pull request May 26, 2020
@riptl
Copy link
Contributor Author

riptl commented May 26, 2020

@patrickjahns Thank you, deployed 1.3.1 and seeing no issues with Promtail 1.5.0!

@patrickjahns
Copy link
Owner

Great - will check the release notes and bump the default promtail version then as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants