Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Base64 Impl from OpenJDK (GPL2) to Apache #8

Closed
patrickfav opened this issue Jul 26, 2018 · 4 comments
Closed

Switch Base64 Impl from OpenJDK (GPL2) to Apache #8

patrickfav opened this issue Jul 26, 2018 · 4 comments
Assignees
@patrickfav
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@patrickfav
Copy link
Owner

So it seems, if I use OpenJDK source, the whole library will be be GPL v2.

It is better to modify the https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/binary/Base64.html Apache Commons Codec version.
@patrickfav patrickfav added the enhancement New feature or request label Jul 26, 2018
@patrickfav patrickfav added this to the v0.5.0 milestone Jul 26, 2018
@patrickfav patrickfav self-assigned this Jul 26, 2018
@patrickfav
Copy link
Owner Author

patrickfav commented Jul 26, 2018 •
edited
Loading

refs #2

@patrickfav
Copy link
Owner Author

Here is the discussion about the license: https://opensource.stackexchange.com/questions/7164/i-modified-and-used-gpl2-code-in-my-apache-2-open-source-project-can-my-projec/7165#7165

patrickfav added a commit that referenced this issue Jul 31, 2018
@patrickfav
First working implementation of Apache Codec Base64/Radix64 mod
3c8320c 
#8
patrickfav added a commit that referenced this issue Jul 31, 2018
@patrickfav
Swap Base64 implementation with Apache Commons Codec
dbdcb77 
ref #8
patrickfav added a commit that referenced this issue Jul 31, 2018
@patrickfav
Swap Base64 implementation with Apache Commons Codec
215668f 
ref #8
@patrickfav patrickfav mentioned this issue Jul 31, 2018
Merged
@patrickfav
Copy link
Owner Author

So actually Im not a fan of the Apache Codec Commons implementations seems to focus on code reusability than performance and concisenes. A lot of the lib seems really messy (there is a second Base64 impl e.g. and some exotic codecs and Message Digest impls for any reason)

@patrickfav
Copy link
Owner Author

Merged.

patrickfav added a commit that referenced this issue Aug 9, 2018
@patrickfav
Switch to Okio Base64 implementation
97c0699 
#8
@patrickfav patrickfav mentioned this issue Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickfav patrickfav

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@patrickfav