Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-existed open graph and twitter properties #286

Open
wants to merge 11 commits into
base: dev/Umbraco11
Choose a base branch
from

Conversation

ugurhangul
Copy link

Added non-existed open graph and twitter properties along with new open graph and twitter groups,
Added default option for dropdown property,
Added SeoVideoEditEditor media picker property,
Solved MetaFieldsTagHelper.cs null exception bug when MediaPicker property null,
Facebook App Id title changed.

@ugurhangul
Copy link
Author

Known bug;

Image and Video editor fallback values sets as class name

@dederuhi
Copy link

great enhancement

@patrickdemooij9
Copy link
Owner

Hi @ugurhangul

Thank you for this huge Pull request! It looks very good! I did also spot the same issue as you with the Image and Video editor fallback values sets as class name. And now that we have sections for all the different social websites, the previewers probably should just use the corresponding one (so twitter section = twitter previewer) instead of all.

But other than that, this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants