Added option to supress the "SEO settings have been saved" notification #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes a lot of sense and testing is all good too! Thank you for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
During development I (we) find it very annoying that each time you edit an document type, you get the seo settings have been saved, when there have been no changes to it.
Ideally the models should be compared (on load and on save) and shown the proper notification for it. But that's a lot more work :-)
I've added an configurable option so you can suppress the "SEO settings have been saved" notification, so you aren't muscle memoried / tricked (clicking the next doc type on appearal of green notification) when the documentType settings hasn't been saved yet but the seosettings have been :) I think this is ideal for a user's development environment.
If I interpreted correctly, the seosettings-save is always done before the doctype-save, so no issues should appear.