Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added import functionality for redirects module #284

Merged

Conversation

Ambertvu
Copy link
Contributor

@Ambertvu Ambertvu commented Aug 9, 2024

Title says it all.

Added option to import redirects by a Csv / Excel file

Things I might add based on feedback

Currently forces all added redirects to 301. Not sure if this should be an option / field in the import sheet
Currently only supports 2 cells, a from and to url and only plain text (so no regex)
Might add feature that also checks the imported url and gives a warning/notification based on if there is a page at all for that url.
    Example: I have a 'toUrl' called '/some-news-page'. But that page does not exists in the CMS, could be nice to give a warning
    Example: I have a 'fromUrl' called '/some-news-page'. But that page exists in the CMS, could be nice to give a warning

Feedback / improvements are always welcome!

@patrickdemooij9
Copy link
Owner

Hi @Ambertvu

I was just able to test out the changes made, looks super good! Did run into some issues (added them as comments to the PR), but I think this can all be merged when those are resolved. Let me know if you have time to do that otherwise I can see if I can pick them up. But super happy with this functionality!

@Ambertvu
Copy link
Contributor Author

Good to hear @patrickdemooij9 !

Did a few updates here and there as well, thanks so far!

@patrickdemooij9 patrickdemooij9 merged commit 97d4600 into patrickdemooij9:dev/Umbraco11 Sep 11, 2024
@patrickdemooij9
Copy link
Owner

Merged back! Thank you so much for your contribution @Ambertvu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants