Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling SectionTree for ScriptManager #210

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

kows
Copy link
Contributor

@kows kows commented Jun 30, 2023

https://seotoolkit.gitbook.io/useotoolkit/settings/disabling
This is an option according to the documentation but doesn't work atm.

@patrickdemooij9 patrickdemooij9 merged commit 2607d55 into patrickdemooij9:dev/Umbraco11 Jul 4, 2023
@patrickdemooij9
Copy link
Owner

Hi @kows
Thank you for the PR, can't believe I added that to the documentation and then forgot to add it in the code.
As you can see, I added some extra changes to your PR, nothing major though.

The DisabledModuleConstant should have been SectionTree instead of Tree and the else statement wasn't needed. Just some minor changes.

Thank you for the PR. I'll merge it and it'll be in the next release!

@patrickdemooij9
Copy link
Owner

Somehow I merged the PR without my changes in it... But they are in this commit if you want to see them: 25e9b41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants