Add content to MetaTagsNotification objects #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ianleeder, |
ianleeder
commented
Jun 1, 2023
| @@ -7,11 +9,20 @@ public class AfterMetaTagsNotification : INotification | |||
| { | |||
| public string ContentTypeAlias { get; } | |||
| public MetaTagsModel MetaTags { get; } | |||
| public IPublishedContent Content { get; set; } | |||
There was a problem hiding this comment.
@patrickdemooij9
I just saw that I allowed set on the automatic property. This should probably be updated to get only, like the other properties. Just habit (and auto-complete).
There was a problem hiding this comment.
(I don't use GitHub PRs very often. I couldn't see a way to amend or reopen this one once it was merged. Let me know if there was an easier way to do this. A second PR feels like overkill)
patrickdemooij9
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Ian Leeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
Ideally I would have removed the original
(string contentTypeAlias, MetaTagsModel metaTags)constructors, but I kept them for strict backwards compatibility. I struggle to imagine a scenario where end-users are creating these classes themselves, but they are public, and it is possible.Again, this was based
dev/Umbraco10