Add processing for url fragments to vimwiki_link

[djeremiah]

Added some processing for links with url fragments, such as those generated by :VimwikiTOC or or when using a diary_caption_level >0

[patrickdavey]

Thanks @djeremiah - looks good 👍

[patrickdavey]

I've pushed out 0.4.2 , should be good to update now. Thanks again.

[patrickdavey]

Hmmm, actually, this is going to break people's links ... for example, this spec will fail now

    it "should not alter fragments which are part of a url" do
      markdown_link = "[test](http://foo#Bar)"

      link = VimwikiLink.new(markdown_link, source_filepath, markdown_extension, root_path)
      expect(link.title).to eq("test")
      expect(link.uri).to eq("http://foo#Bar")
    end

What do you think should be the expected behavior @djeremiah ? I think maybe we shouldn't perform any transforms on the fragment if the uri isn't local? I don't use the table of contents so I'm not too sure about this one.

I think in the meantime I'm going to revert 0.4.2 until this is sorted out.

[djeremiah]

Ah nuts, I didn't think about that, was focused on fixing up the generated links.

It's a tricky one, because there's no way to tell the difference between a markdown link that's been generated by vimwiki and one that's been handwritten. I think it's safe to do inside the vimwiki_markdown_file_exists? block, since that virtually guarantees it's a vimwiki link. For the fragment-only case, I'm not sure.

I can live without the generated TOC, so maybe that could be deferred. I've updated my feature branch to reflect this approach.

[patrickdavey]

I'm happy to do it myself, but, if you have time, can you rebase your branch against master (as I reverted your changes) and then open a new PR? I'm off to bed here anyway (NZ!), so, I'll get to this tomorrow :)

I think the idea of just doing it inside the local block seems sensible. Can always do that until we get an issue telling us we broke stuff. Hurrah for never reaching 1.0 ;)