Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Implement include and exclude option - close #22. #62

Merged
merged 5 commits into from
Oct 23, 2022

Conversation

douglasmakey
Copy link
Contributor

Hey, thanks for this great tool!

This proposal to implement included and excluded is quite simple. It is about merging all the supported filters and using the same logic to compare whether the files must be included or excluded.

I look forward to hearing what you think 👀!

Copy link
Owner

@patrickdappollonio patrickdappollonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks a lot for sending this in. I left a few comments regarding presentation and an important one about regexp.

app.go Outdated Show resolved Hide resolved
app.go Outdated Show resolved Hide resolved
slice/validate.go Outdated Show resolved Hide resolved
slice/validate.go Outdated Show resolved Hide resolved
slice/validate.go Outdated Show resolved Hide resolved
slice/validate.go Outdated Show resolved Hide resolved
douglasmakey and others added 4 commits October 21, 2022 16:25
Co-authored-by: Patrick D'appollonio <[email protected]>
Co-authored-by: Patrick D'appollonio <[email protected]>
formating error

Co-authored-by: Patrick D'appollonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants