Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides simple mechanism to support using cached nodes #81

Conversation

AutoSponge
Copy link
Collaborator

@AutoSponge AutoSponge commented Sep 4, 2016

also supports nodes that get augmented outside of the morphdom render cycle
closes #77

…t get augmented outside of the morphdom render cycle
@yoshuawuyts
Copy link

I like the efficiency of the implementation, but I wonder though if it's a good idea to make this rely on non-native DOM methods. I think it might be worth it as there's little drawback, but I feel we should definitely ponder if this is the way we want to go.

@AutoSponge
Copy link
Collaborator Author

AutoSponge commented Sep 4, 2016

@yoshuawuyts isSameNode is a native method. Was there another method you were referring to?

EDIT: I guess, the need to polyfill that method for other browsers becomes either a job for morphdom or an exercise for the implementer

@yoshuawuyts
Copy link

@AutoSponge woah, I had no idea. This is great 💯

@AutoSponge
Copy link
Collaborator Author

I will still put in a check so it doesn't blow up in IE7-8.

@patrick-steele-idem patrick-steele-idem merged commit 3d4be15 into patrick-steele-idem:master Sep 6, 2016
@yoshuawuyts
Copy link

YESSSSS! 🎉

@patrick-steele-idem
Copy link
Owner

Thanks for the improvement! I will be including this release that will go out soon. I'm also working on some performance improvements and am also working on adding support for diffing the real DOM with a virtual DOM (that implements the same API as the real DOM). Thanks, again.

@yoshuawuyts
Copy link

@patrick-steele-idem when do you expect the release to come out? Lots of folks upstream are super stoked to start using this 😁

@patrick-steele-idem
Copy link
Owner

@yoshuawuyts Sorry, I became super focused on benchmarking and optimizing. I promise I will publish by EOD today.

@patrick-steele-idem
Copy link
Owner

Alright, new version published with support for isSameNode and diffing with virtual DOM nodes: [email protected]

Please let me know if you see any issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memoized elements are removed & added anyway
3 participants