-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provides simple mechanism to support using cached nodes #81
provides simple mechanism to support using cached nodes #81
Conversation
…t get augmented outside of the morphdom render cycle
I like the efficiency of the implementation, but I wonder though if it's a good idea to make this rely on non-native DOM methods. I think it might be worth it as there's little drawback, but I feel we should definitely ponder if this is the way we want to go. |
@yoshuawuyts EDIT: I guess, the need to polyfill that method for other browsers becomes either a job for morphdom or an exercise for the implementer |
@AutoSponge woah, I had no idea. This is great 💯 |
I will still put in a check so it doesn't blow up in IE7-8. |
YESSSSS! 🎉 |
Thanks for the improvement! I will be including this release that will go out soon. I'm also working on some performance improvements and am also working on adding support for diffing the real DOM with a virtual DOM (that implements the same API as the real DOM). Thanks, again. |
@patrick-steele-idem when do you expect the release to come out? Lots of folks upstream are super stoked to start using this 😁 |
@yoshuawuyts Sorry, I became super focused on benchmarking and optimizing. I promise I will publish by EOD today. |
Alright, new version published with support for Please let me know if you see any issues. Thanks! |
also supports nodes that get augmented outside of the morphdom render cycle
closes #77