Release 2.7.4

patrick-steele-idem · Jul 19, 2024 · c710ec7 · c710ec7
1 parent b1b0797
commit c710ec7
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,9 @@ Changelog
 
 # 2.x
 
+## 2.7.4
+- Fix incorrect index references when returning a cloned tree from onBeforeElUpdated
+
 ## 2.7.3
 - Allow returning a new fromEl tree from onBeforeElUpdated to be used morph for that branch
 

diff --git a/dist/morphdom-esm.js b/dist/morphdom-esm.js
@@ -496,6 +496,11 @@ function morphdomFactory(morphAttrs) {
           return;
         } else if (beforeUpdateResult instanceof HTMLElement) {
           fromEl = beforeUpdateResult;
+          // reindex the new fromEl in case it's not in the same
+          // tree as the original fromEl
+          // (Phoenix LiveView sometimes returns a cloned tree,
+          //  but keyed lookups would still point to the original tree)
+          indexTree(fromEl);
         }
 
         // update attributes on original DOM element first

diff --git a/dist/morphdom-factory.js b/dist/morphdom-factory.js
@@ -434,6 +434,11 @@ function morphdomFactory(morphAttrs) {
           return;
         } else if (beforeUpdateResult instanceof HTMLElement) {
           fromEl = beforeUpdateResult;
+          // reindex the new fromEl in case it's not in the same
+          // tree as the original fromEl
+          // (Phoenix LiveView sometimes returns a cloned tree,
+          //  but keyed lookups would still point to the original tree)
+          indexTree(fromEl);
         }
 
         // update attributes on original DOM element first

diff --git a/dist/morphdom-umd.js b/dist/morphdom-umd.js
@@ -502,6 +502,11 @@
               return;
             } else if (beforeUpdateResult instanceof HTMLElement) {
               fromEl = beforeUpdateResult;
+              // reindex the new fromEl in case it's not in the same
+              // tree as the original fromEl
+              // (Phoenix LiveView sometimes returns a cloned tree,
+              //  but keyed lookups would still point to the original tree)
+              indexTree(fromEl);
             }
 
             // update attributes on original DOM element first

diff --git a/dist/morphdom-umd.min.js b/dist/morphdom-umd.min.js
diff --git a/dist/morphdom.js b/dist/morphdom.js
@@ -498,6 +498,11 @@ function morphdomFactory(morphAttrs) {
           return;
         } else if (beforeUpdateResult instanceof HTMLElement) {
           fromEl = beforeUpdateResult;
+          // reindex the new fromEl in case it's not in the same
+          // tree as the original fromEl
+          // (Phoenix LiveView sometimes returns a cloned tree,
+          //  but keyed lookups would still point to the original tree)
+          indexTree(fromEl);
         }
 
         // update attributes on original DOM element first

diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     "virtual-dom": "^2.1.1"
   },
   "dependencies": {},
-  "version": "2.7.3",
+  "version": "2.7.4",
   "keywords": [
     "dom",
     "diff",