Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): notify about tree_at bypassing checks #874

Closed
wants to merge 1 commit into from

Conversation

jeertmans
Copy link

Hi @patrick-kidger!

Here is a first proposal. I am not entirely convinced by my wording, but let me know what you think of it.

Closes #872

Hi @patrick-kidger!

Here is a first proposal. I am not entirely convinced by my wording, but let me know what you think of it.

Closes patrick-kidger#872
@patrick-kidger
Copy link
Owner

I think this looks pretty good! I think the only thing I'd tweak is to express is (a) that there are good reasons for this and (b) what those good reasons are. (Otherwise it just sounds like we decided not to implement this for some reason! :D )

@jeertmans
Copy link
Author

I think this looks pretty good! I think the only thing I'd tweak is to express is (a) that there are good reasons for this and (b) what those good reasons are. (Otherwise it just sounds like we decided not to implement this for some reason! :D )

Sure, I didn’t want to write those reasons myself as I didn’t want to be incorrect, and I also wanted to be concise and didn’t know the proper wording to this end :)

patrick-kidger added a commit that referenced this pull request Oct 12, 2024
@patrick-kidger
Copy link
Owner

Fair enough! I've modified this in #877 :)

@jeertmans
Copy link
Author

Nice, I guess I can close this now, I am leaving a few comments on the other PR :-)

@jeertmans jeertmans closed this Oct 12, 2024
patrick-kidger added a commit that referenced this pull request Oct 12, 2024
patrick-kidger added a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree_at silently skips __check_init__
2 participants