Fix MyPy's view of _ModuleMeta #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The downside of this approach is that it means we lose type-checking within the definition of Would something like the following work instead? # As today, but the name has an additional underscore
class __ModuleMeta(ABCMeta):
...
if TYPE_CHECKING:
class _ModuleMeta: ... # as today
else:
_ModuleMeta = __ModuleMeta? |
|
Yup, that's a good idea! |
|
Looks like tests are failing (due to something to do with name mangling). Other than that, LGTM! |
NeilGirdhar
force-pushed
the
fix_mypy
branch
2 times, most recently
from
8abe260 to
3f41f71
Compare
|
Fixes #820 |
|
Wonderful stuff. LGTM, and merged! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.