correct fix for #31

patman15 · Jul 3, 2024 · c532dae · c532dae
1 parent 972d77b
commit c532dae
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/custom_components/bms_ble/plugins/ogt_bms.py b/custom_components/bms_ble/plugins/ogt_bms.py
@@ -68,7 +68,7 @@ def __init__(self, ble_device: BLEDevice, reconnect: bool = False) -> None:
             self._ble_device.name[10:],
             self._key,
         )
-        self._values: BMSsample = {}  # dictionary of BMS return values
+        self._values: BMSsample  # dictionary of BMS return values
         self._REGISTERS: dict[int, tuple[str, int, Callable[[int], int | float] | None]]
         if self._type == "A":
             self._REGISTERS = {
@@ -98,7 +98,13 @@ def __init__(self, ble_device: BLEDevice, reconnect: bool = False) -> None:
                 23: (ATTR_CYCLES, 2, None),
             }
             # add cell voltage registers, note need to be last!
-            self._REGISTERS.update({63-reg: (f"{KEY_CELL_VOLTAGE}{reg+1}", 2, lambda x: float(x)/1000) for reg in range(16)})
+            self._REGISTERS.update(
+                {
+                    63
+                    - reg: (f"{KEY_CELL_VOLTAGE}{reg+1}", 2, lambda x: float(x) / 1000)
+                    for reg in range(16)
+                }
+            )
             self._HEADER = "+R16"
         else:
             self._REGISTERS = {}
@@ -134,7 +140,7 @@ async def async_update(self) -> BMSsample:
 
         await self._connect()
 
-        self._values.clear()
+        self._values = {}
         for key in list(self._REGISTERS):
             await self._read(key)
             try:
@@ -145,7 +151,8 @@ async def async_update(self) -> BMSsample:
                 break
 
         self.calc_values(
-            self._values, {ATTR_CYCLE_CAP, ATTR_POWER, ATTR_BATTERY_CHARGING, ATTR_DELTA_VOLTAGE}
+            self._values,
+            {ATTR_CYCLE_CAP, ATTR_POWER, ATTR_BATTERY_CHARGING, ATTR_DELTA_VOLTAGE},
         )
 
         if self._reconnect: