Remove support for list item with * #28
Conversation
Build changes Fix the package-lock Fix the package-lock
|
Thanks for updating this. I'm thinking we should update the minor version to reflect this fairly large change. What do you think? Also, do you think we should pin the dependency in the package.json to the latest version? |
| @@ -186,7 +186,7 @@ class MarkdownShortcuts { | |||
| }, | |||
| { | |||
| name: 'asterisk-ul', | |||
| pattern: /^(\*|\+)\s$/g, | |||
| pattern: /^\+\s$/g, | |||
There was a problem hiding this comment.
Can you add a note somewhere here that the asterisk was removed in quill version xx.xx.xx?
Thanks.
There was a problem hiding this comment.
I added a comment the line above.
|
@patleeman Thanks for your review, I've added a comment and updated the version. I can squash the commit for another PR if needed.
I don't think it's necessary but maybe I am missing something. |
|
Hey @patleeman ! Any news on this? Thanks again for the project :) |
|
Thanks for the work on this @p-salmon |
|
Hey @patleeman ! It's been a while but would be nice to have a new version with this fix ^^ Thanks! |
With the latest version of Quill, the support for list starting with
*has been added by default:slab/quill#1819
The following line were conflicting with this behaviour, creating weird behaviour where two lines were being cleaned.
We've removed the support for
*but let the support for+.We haven't renamed the match and let the
asterisk-listintentionally, happy to change it if needed.Thanks again for the awesome project, it's been really useful for us!