handle rt and plain indices the same #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostadinov
commented
Aug 10, 2023
| @@ -6,7 +6,7 @@ | |||
| let(:indices) { [index_a, index_b] } | |||
| let(:index_a) { double 'Index A', :model => model_a, :type => 'plain', | |||
| :sources => [double(:fields => [field_a1, field_a2])] } | |||
| let(:index_b) { double 'Index B', :model => model_a, :type => 'rt', | |||
| let(:index_b) { double 'Index B', :model => model_b, :type => 'rt', | |||
There was a problem hiding this comment.
This got me in trouble originally. index_a should use model_a and index_b should use model_b as far as I understand the intention of the test case.
There was a problem hiding this comment.
As much as I can tell, yes, I think you're right! Thanks for this PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of my oversight in #1222 all rt indices lost the
sphinx_internal_class_namefield and this is not correct. In either index type, when single table inheritance is used, thensphinx_internal_class_nameshould be present. Now also added a test for it - to make sure both index types are handled.