Replace deprecated imp module with importlib #75
Comments
cdent
added a commit
that referenced
this issue
Apr 30, 2023
imp is deprecated and will go away in Python 3.12 (which is very soon). This implementation based on the importlib docs [1] and passes the quite robust tests that are already present for the urlparser module. Unfortunately there's no good way to be 100% certain that this works for all the many ways that Paste can do an import. So this patch is mostly hoping that test coverage is sufficient. [1] https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly Fixes #75
|
If you're able toggle #76 a review to confirm that I've adjusted things appropriately, that would be very helpful. Thanks! |
cdent
added a commit
that referenced
this issue
Apr 30, 2023
imp is deprecated and will go away in Python 3.12 (which is very soon). The preferred replacement is importlib. However, importlib is not available in Python 2.7, so we want to keep both in order to maintain 2.7 some semblance of 2.7 support. This implementation is based on the importlib docs [1] and passes the quite robust tests that are already present for the urlparser module. Unfortunately there's no good way to be 100% certain that this works for all the many ways that Paste can do an import. So this patch is mostly hoping that test coverage is sufficient. [1] https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly Fixes #75
cdent
added a commit
that referenced
this issue
Apr 30, 2023
imp is deprecated and will go away in Python 3.12 (which is very soon). The preferred replacement is importlib. However, importlib is not available in Python 2.7, so we want to keep both in order to maintain 2.7 some semblance of 2.7 support. This implementation is based on the importlib docs [1] and passes the quite robust tests that are already present for the urlparser module. Unfortunately there's no good way to be 100% certain that this works for all the many ways that Paste can do an import. So this patch is mostly hoping that test coverage is sufficient. [1] https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly Fixes #75
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This project uses the
impmodule which has been deprecated since Python 3.4 and removed in 3.12:PendingDeprecationWarningsince 3.4 (2014)DeprecationWarningsince 3.5 (2015)DeprecationWarningto say removal in 3.12 since 3.10 (2021)Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.
Please could you upgrade to use
importlib? Theimpdocs have suggestions on what to use to replace each function and constant.The text was updated successfully, but these errors were encountered: