Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard orgin url feature #583

Closed

Conversation

jackaboy7981
Copy link

@jackaboy7981 jackaboy7981 commented Dec 9, 2024

This PR is regarding allowing fido passwordless flow from subdomain using wildcard url in origin

so you can set origin to https://*.example.com to accept all subdomains of example.com
Eg: https://sub.example.com
@abergs

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.88%. Comparing base (f8471ac) to head (8bbc19f).

Files with missing lines Patch % Lines
Src/Fido2.Models/StringExtensions.cs 58.82% 4 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   76.03%   75.88%   -0.15%     
==========================================
  Files         101      101              
  Lines        2600     2613      +13     
  Branches      432      437       +5     
==========================================
+ Hits         1977     1983       +6     
- Misses        513      517       +4     
- Partials      110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackaboy7981
Copy link
Author

@jackaboy7981 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that you took time and provided a contribution. However, before progressing with this PR and taking on the responsibility of reg'ex matching URI's, I believe this discussion should be had: #538 (reply in thread)

@abergs
Copy link
Collaborator

abergs commented Jan 10, 2025

Since the discussion have showed examples on how to achieve this, I will be closing this PR. If the library need to change, we can re-open.

I have also filed an issue to improve the examples for this advanced use case.

@abergs abergs closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants