Change TPM manufacturer sting comparison handling #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s effectively the same as 49424D00
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 76.96% 76.97%
=======================================
Files 100 100
Lines 2613 2614 +1
Branches 441 441
=======================================
+ Hits 2011 2012 +1
Misses 496 496
Partials 106 106 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to what is probably a simple typo that got overlooked in the TPM spec, the manufacturer identifier assigned to IBM ended up with a lowercase 'D' character in what was supposed to be a simple ASCII to hexadecimal mapping. This change compensates for that by trimming the
id:portion of the TPMManufacturer string, then converting the remainder to a hex string.By doing this,
id:49424d00andid:49424D00will effectively be the same, without changing the existing static strings from the spec.Resolves #545, where more info is available.