Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AuthenticatorSelection.Default ResidentKey from discouraged to Preferred #563

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

abergs
Copy link
Collaborator

@abergs abergs commented Oct 29, 2024

This change aims to help the consumers move towards discoverable passkeys instead of defaulting to non-resident/2fa type of credentials.

This resolves #561.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (94f6071) to head (712da67).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Src/Fido2.Models/CredentialCreateOptions.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         100      100           
  Lines        2627     2627           
  Branches      441      441           
=======================================
  Hits         2021     2021           
  Misses        498      498           
  Partials      108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs abergs added this to the Version 4 milestone Nov 5, 2024
@abergs abergs merged commit 8f50921 into master Nov 12, 2024
11 checks passed
@abergs abergs deleted the change-default branch November 12, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change AuthenticatorSelection.Defaultto prefer ResidentKey (discoverable keys)
2 participants