Introduce wrapping objects for Options-methods #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might want to take a peak here too @iamcarbon |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 74.72% 74.45% -0.28%
==========================================
Files 103 105 +2
Lines 2730 2740 +10
Branches 464 464
==========================================
Hits 2040 2040
- Misses 581 591 +10
Partials 109 109 ☔ View full report in Codecov by Sentry. |
|
Will merge this in the next day, but I still welcome opinions if you have any @iamcarbon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns with #556 and resolves #560.
In order to let the API surface grow (e.g. introducing Hints, allow RPs to select algo's to support, etc) we want to move towards this more flexible approach.
The main downside I see is that it's harder for devs to know which arguments are the main arguments without reading docs. Not sure how to best adress that, since most arguments used are not required.