Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PublicKeyCredentialHint for WebAuthn L3 #524

Merged

Conversation

jonashendrickx
Copy link
Contributor

@jonashendrickx jonashendrickx commented Jul 6, 2024

Implements WebAuthn L3 PublicKeyCredentialHints:

When the Hints property is set on CredentialCreateOptions, AuthenticatorSelection.AuthenticatorAttachment will be set to CrossPlatform to match the spec for backwards compatibility. By default the Hints property will be null.

Depends on PR #525 to make the build and tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.04%. Comparing base (b1157a5) to head (f08a91d).

Files Patch % Lines
Src/Fido2.Models/CredentialCreateOptions.cs 7.69% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   74.36%   74.04%   -0.32%     
==========================================
  Files         100      100              
  Lines        2641     2655      +14     
  Branches      443      446       +3     
==========================================
+ Hits         1964     1966       +2     
- Misses        576      588      +12     
  Partials      101      101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks mostly good, see comment on AuthenticatorAttachment.

Also - this PR is missing the implementation on assertion - hints are supported there too, not only on create.

Src/Fido2.Models/CredentialCreateOptions.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this makes sense!

@abergs abergs merged commit df37692 into passwordless-lib:master Jul 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants