-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PublicKeyCredentialHint for WebAuthn L3 #524
Implement PublicKeyCredentialHint for WebAuthn L3 #524
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 74.36% 74.04% -0.32%
==========================================
Files 100 100
Lines 2641 2655 +14
Branches 443 446 +3
==========================================
+ Hits 1964 1966 +2
- Misses 576 588 +12
Partials 101 101 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks mostly good, see comment on AuthenticatorAttachment.
Also - this PR is missing the implementation on assertion - hints are supported there too, not only on create.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, this makes sense!
Implements WebAuthn L3 PublicKeyCredentialHints:
When the
Hints
property is set onCredentialCreateOptions
,AuthenticatorSelection.AuthenticatorAttachment
will be set toCrossPlatform
to match the spec for backwards compatibility. By default theHints
property will be null.Depends on PR #525 to make the build and tests pass.