Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop assertion-time attestation #499

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Drop assertion-time attestation #499

merged 1 commit into from
Feb 12, 2024

Conversation

joegoldman2
Copy link
Contributor

Fixes #496.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a9886d) 73.94% compared to head (ec5b7c5) 74.44%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   73.94%   74.44%   +0.50%     
==========================================
  Files          99       99              
  Lines        2698     2677      -21     
  Branches      461      455       -6     
==========================================
- Hits         1995     1993       -2     
+ Misses        598      580      -18     
+ Partials      105      104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs abergs requested review from aseigler and abergs February 8, 2024 15:08
Copy link
Collaborator

@aseigler aseigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abergs abergs merged commit b597d18 into passwordless-lib:master Feb 12, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the fix/496 branch February 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop assertion-time attestation
4 participants