Skip to content

Commit

Permalink
Adress feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
abergs committed Oct 28, 2024
1 parent 8191606 commit fa91b0f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Src/Fido2/Fido2.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public CredentialCreateOptions RequestNewCredential(
/// <summary>
/// Verifies the response from the browser/authenticator after creating new credentials.
/// </summary>
/// <param name="makeNewCredentialParams">Wraps the input parameters for making a new credential</param>
/// <param name="makeNewCredentialParams">The input arguments for creating a passkey</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
/// <returns></returns>
public async Task<RegisteredPublicKeyCredential> MakeNewCredentialAsync(MakeNewCredentialParams makeNewCredentialParams,
Expand Down Expand Up @@ -94,7 +94,7 @@ public AssertionOptions GetAssertionOptions(
/// <summary>
/// Verifies the assertion response from the browser/authenticator to assert existing credentials and authenticate a user.
/// </summary>
/// <param name="makeAssertionParams">Wraps the input arguments for asserting a passkey</param>
/// <param name="makeAssertionParams">The input arguments for asserting a passkey</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
/// <returns></returns>
public async Task<VerifyAssertionResult> MakeAssertionAsync(MakeAssertionParams makeAssertionParams,
Expand Down
3 changes: 2 additions & 1 deletion Src/Fido2/MakeAssertionParams.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.ComponentModel;

namespace Fido2NetLib;

Expand Down Expand Up @@ -38,9 +39,9 @@ public sealed class MakeAssertionParams
/// </summary>
public IReadOnlyList<byte[]> StoredDevicePublicKeys { get; init; } = Array.Empty<byte[]>();


/// <summary>
/// DO NOT USE - Deprecated, but kept in code due to conformance testing tool.
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public byte[]? RequestTokenBindingId { get; init; }
}
5 changes: 4 additions & 1 deletion Src/Fido2/MakeNewCredentialParams.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
namespace Fido2NetLib;
using System.ComponentModel;

namespace Fido2NetLib;

/// <summary>
/// Wraps the input for the MakeNewCredential function
Expand All @@ -23,5 +25,6 @@ public sealed class MakeNewCredentialParams
/// <summary>
/// DO NOT USE - Deprecated, but kept in code due to conformance testing tool
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public byte[]? RequestTokenBindingId { get; init; }
}

0 comments on commit fa91b0f

Please sign in to comment.