Skip to content

Commit

Permalink
Rename clientDataJson to clientDataJSON (#450)
Browse files Browse the repository at this point in the history
* Rename `clientDataJson` to `clientDataJSON`

* JSON -> Json
  • Loading branch information
joegoldman2 authored Nov 10, 2023
1 parent 8187db5 commit 4774980
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion BlazorWasmDemo/Server/Controllers/UserController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public async Task<string> CreateCredentialAsync([FromRoute] string username, [Fr
IsBackupEligible = result.Result.IsBackupEligible,
IsBackedUp = result.Result.IsBackedUp,
AttestationObject = result.Result.AttestationObject,
AttestationClientDataJSON = result.Result.AttestationClientDataJson,
AttestationClientDataJson = result.Result.AttestationClientDataJson,
});

// 5. Now we need to remove the options from the pending dictionary
Expand Down
2 changes: 1 addition & 1 deletion Demo/Controller.cs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public async Task<JsonResult> MakeCredential([FromBody] AuthenticatorAttestation
IsBackupEligible = success.Result.IsBackupEligible,
IsBackedUp = success.Result.IsBackedUp,
AttestationObject = success.Result.AttestationObject,
AttestationClientDataJSON = success.Result.AttestationClientDataJson,
AttestationClientDataJson = success.Result.AttestationClientDataJson,
DevicePublicKeys = new List<byte[]>() { success.Result.DevicePublicKey }
});

Expand Down
2 changes: 1 addition & 1 deletion Demo/wwwroot/js/custom.register.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ async function registerNewCredential(newCredential) {
extensions: newCredential.getClientExtensionResults(),
response: {
AttestationObject: coerceToBase64Url(attestationObject),
clientDataJson: coerceToBase64Url(clientDataJSON),
clientDataJSON: coerceToBase64Url(clientDataJSON),
transports: newCredential.response.getTransports(),
},
};
Expand Down
2 changes: 1 addition & 1 deletion Src/Fido2.Development/StoredCredential.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class StoredCredential
/// The value of the clientDataJSON attribute when the public key credential source was registered.
/// Storing this in combination with the above attestationObject item enables the Relying Party to re-verify the attestation signature at a later time.
/// </summary>
public byte[] AttestationClientDataJSON { get; set; }
public byte[] AttestationClientDataJson { get; set; }

public List<byte[]> DevicePublicKeys { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion Test/TestFiles/assertionNoneResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "public-key",
"response": {
"authenticatorData": "SZYN5YgOjGh0NBcPZHZgW4_krrmihjLHmVzzuoMdl2MBAAAANA",
"clientDataJson": "eyJjaGFsbGVuZ2UiOiJiTmhCaGk5SklURVF1WU5QbHhvSEhqMGt6TnNWU0xNVk0wSmZnU2NQWmlTN25HRjUxb21HU05MWTYxRkJaODRnRzVuUngwRUwwdEM4VGhybDBBYXpjZyIsIm9yaWdpbiI6Imh0dHBzOi8vbG9jYWxob3N0OjQ0MzI5IiwidHlwZSI6IndlYmF1dGhuLmdldCJ9",
"clientDataJSON": "eyJjaGFsbGVuZ2UiOiJiTmhCaGk5SklURVF1WU5QbHhvSEhqMGt6TnNWU0xNVk0wSmZnU2NQWmlTN25HRjUxb21HU05MWTYxRkJaODRnRzVuUngwRUwwdEM4VGhybDBBYXpjZyIsIm9yaWdpbiI6Imh0dHBzOi8vbG9jYWxob3N0OjQ0MzI5IiwidHlwZSI6IndlYmF1dGhuLmdldCJ9",
"signature": "3046022100f20793dc46905c62fdbc309506b59c7cfa4fafc42dc2e51af4e58f474f64ba78022100c550af5e6516816517ddf83706fab02fe6287c04c8747a0621949456792111b6",
"userHandle": null
}
Expand Down

0 comments on commit 4774980

Please sign in to comment.