Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KtIterable.minWith returned max #88

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

passsy
Copy link
Owner

@passsy passsy commented Mar 27, 2019

There was a copy-paste error in the tests hiding the wrong implementation of minWith. minBy worked as expected

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          41       41           
  Lines        1845     1845           
=======================================
  Hits         1842     1842           
  Misses          3        3
Impacted Files Coverage Δ
...collection/extension/iterable_extension_mixin.dart 99.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8589a...350a24a. Read the comment docs.

@passsy passsy merged commit ee77131 into master Mar 27, 2019
@passsy passsy deleted the feature/fix_minWith_returned_max branch March 27, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant