Introduce minOf() on KtIterable #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 39 39
Lines 1774 1781 +7
=======================================
+ Hits 1760 1767 +7
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
passsy
reviewed
Oct 14, 2021
| /// Returns the smallest value among all values produced by selector function applied to each element in the array. | ||
| /// | ||
| /// Throws a [NoSuchElementException] if the list is empty. | ||
| R minOf<R extends Comparable>(R Function(T) selector) { |
There was a problem hiding this comment.
Shouldn't the selector be optional?
There was a problem hiding this comment.
no, kotlins selector is required, too
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157 by adding minOf() method on KtIterable.
Kotlin does not allow to omit the selector function (see example)
If wanted other functions could be checked too to let it be omitted if possible.