Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature - replaceFirstChar #165

Merged
merged 11 commits into from
Oct 15, 2021
Merged

feature - replaceFirstChar #165

merged 11 commits into from
Oct 15, 2021

Conversation

marciokuroki
Copy link
Contributor

  • Implementation
  • Implementation Test

@marciokuroki
feature - replaceFirstChar
f3f393c 
- Implementation
- Implementation Test
passsy
passsy reviewed Oct 10, 2021
View reviewed changes
lib/string.dart Outdated Show resolved Hide resolved
passsy
passsy reviewed Oct 10, 2021
View reviewed changes
lib/string.dart Outdated Show resolved Hide resolved
passsy
passsy reviewed Oct 10, 2021
View reviewed changes
test/issues/issue_161.dart Outdated Show resolved Hide resolved
passsy
passsy reviewed Oct 10, 2021
View reviewed changes
lib/string.dart Outdated Show resolved Hide resolved
passsy
passsy reviewed Oct 10, 2021
View reviewed changes
test/issues/issue_161.dart Outdated Show resolved Hide resolved
@marciokuroki
Copy link
Contributor Author

@passsy Hi. I refactored the solution based on yours comments... Please, review it.

passsy
passsy reviewed Oct 12, 2021
View reviewed changes
lib/string.dart Outdated Show resolved Hide resolved
passsy
passsy reviewed Oct 12, 2021
View reviewed changes
lib/string.dart Outdated Show resolved Hide resolved
passsy
passsy reviewed Oct 12, 2021
View reviewed changes
test/issues/issue_161.dart Outdated Show resolved Hide resolved
passsy
passsy requested changes Oct 12, 2021
View reviewed changes
Copy link
Owner

@passsy passsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement according to Kotlin impl

@marciokuroki
refactoring according comments
e10aaa8 
- remove toUpperCase() toLowerCase() functions
- improve testCases
- refactoring replaceFirstChar function
-
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #165 (87609a6) into master (b8534e2) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   99.22%   99.05%   -0.17%     
==========================================
  Files          39       40       +1     
  Lines        1802     1805       +3     
==========================================
  Hits         1788     1788              
- Misses         14       17       +3
Flag Coverage Δ
unittests 99.05% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/src/string/string.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8534e2...87609a6. Read the comment docs.

@passsy
Copy link
Owner

passsy commented Oct 15, 2021

Thanks for your contribution :)

@passsy passsy merged commit 9cc2506 into passsy:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passsy passsy passsy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marciokuroki @passsy