Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2767 passportxyz migration #2846

Merged
merged 10 commits into from
Sep 10, 2024
Merged

2767 passportxyz migration #2846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
336631c
update infra to support iam on passport.xyz
larisa17 Sep 4, 2024
1d59621
remove comment block
larisa17 Sep 4, 2024
5fc8a00
update all secrets to passport-xyz 1password object
larisa17 Sep 4, 2024
c0ef511
debug test
larisa17 Sep 9, 2024
710453a
update scopes
larisa17 Sep 9, 2024
402e50e
update secret name
larisa17 Sep 9, 2024
228808a
update secret name
larisa17 Sep 9, 2024
5ed9387
update secret name
larisa17 Sep 9, 2024
eb57a03
remove secret name
larisa17 Sep 9, 2024
82ce4bc
rollback linkedin
larisa17 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions infra/aws/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const containerInsightsStatus = stack == "production" ? "enabled" : "disabled";

// Manage secrets & envs for Passport XYZ
const passportXyzIamSecretObject = new aws.secretsmanager.Secret("iam-secret-passport-xyz", {
name: "iam-secret-passport-xyz",
// name: "iam-secret-passport-xyz",
description: "Secrets for Passport IAM on Passport XYZ",
tags: {
...defaultTags,
Expand Down Expand Up @@ -318,7 +318,7 @@ const albPassportXyzTargetGroup = new aws.lb.TargetGroup(`passport-xyz-iam`, {

const albPassportXyzListenerRule = new aws.lb.ListenerRule(`passport-xyz-iam-https`, {
listenerArn: albHttpsListenerArn,
priority: 100, // This needs to be grater than the priority number for passport-scroll-badge-service
priority: 102, // This needs to be grater than the priority number for passport-scroll-badge-service
actions: [
{
type: "forward",
Expand Down Expand Up @@ -365,7 +365,7 @@ const albGitcoinTargetGroup = new aws.lb.TargetGroup(`passport-iam`, {

const albGitcoinListenerRule = new aws.lb.ListenerRule(`passport-iam-https`, {
listenerArn: albHttpsListenerArn,
priority: 101, // This needs to be grater than the priority number for passport-scroll-badge-service
priority: 100, // This needs to be grater than the priority number for passport-scroll-badge-service
actions: [
{
type: "forward",
Expand Down
2 changes: 1 addition & 1 deletion platforms/src/Linkedin/App-Bindings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class LinkedinPlatform extends Platform {

async getOAuthUrl(state: string): Promise<string> {
const linkedinUrl = await Promise.resolve(
`https://www.linkedin.com/oauth/v2/authorization?response_type=code&client_id=${this.clientId}&redirect_uri=${this.redirectUri}&state=${state}&scope=email%20profile`
`https://www.linkedin.com/oauth/v2/authorization?response_type=code&client_id=${this.clientId}&redirect_uri=${this.redirectUri}&state=${state}&scope=r_emailaddress%20r_liteprofile`
);
return linkedinUrl;
}
Expand Down
Loading