Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2457 notificaitons #2603

Merged
merged 18 commits into from
Jul 8, 2024
Merged

2457 notificaitons #2603

merged 18 commits into from
Jul 8, 2024

Conversation

tim-schultz
Copy link
Collaborator

Fixes: #2457

nutrina
nutrina requested changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown menu is not fully visible when only 1 notification exists:

image

nutrina
nutrina reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one more comment: https://github.com/gitcoinco/passport/pull/2603/files#r1666806077

tim-schultz and others added 15 commits July 8, 2024 14:41
@tim-schultz
feat(app): style notification components
4005d45
@tim-schultz
feat(app): fetching notification data
ff1afa8
@tim-schultz
feat: remaining notification logic
82766af
@tim-schultz
fix: python naming convention
a3d00a2
@tim-schultz
feat(app): remaining updates for notifcations
a7ecc5c
@tim-schultz
chore: notification testing
7080141
@larisa17 @tim-schultz
feat(notifications): display notification link only if it was set in db
1d51d07
@tim-schultz
chore: update expired chain data structure and only show notification…
5e0bd08 
…s after one click flow
@tim-schultz
chore: remove logs
4503bf7
@tim-schultz
fix: space between link and content
68d8ee2
@tim-schultz
chore(app): min height for notifications and success for passport wit…
c53f938 
…hout stamps
@tim-schultz
fix(app): content
aed454f
@tim-schultz
fix(app): delete expired stamp if use does not qualify
d9c52f6
@tim-schultz
fix(app): render notifications if error occurs in oneclick
73632e8
@tim-schultz
fix(app): adjust notification positioning for web3modal
15c253c
@tim-schultz tim-schultz merged commit da4aca2 into main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutrina nutrina nutrina requested changes

Assignees
No one assigned
Labels
None yet
Projects
Passport New
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Robust In-App Notification System for Enhanced User Engagement and Compliance (Frontend)
3 participants
@tim-schultz @nutrina @larisa17