Verify eip712 vcs #1702
Merged
Verify eip712 vcs #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oving types we don't yet use (like CredentialStatus)
- added test case to check that stamps created when user claims, as well as the converted ones can be verified with ethers - defined EIP712 specific structure for stamp & input data to avoid common structural errors
lucianHymer
pushed a commit
that referenced
this pull request
Sep 25, 2023
* feat(identity): adding back the eip712 types to the VC proof, but removing types we don't yet use (like CredentialStatus) * feat(identity): removing error logs * feat(identity): fixing EIP712 schema, removing unused attributes * feat(iam): fixed validation of the EIP712 stamps with ethers - added test case to check that stamps created when user claims, as well as the converted ones can be verified with ethers - defined EIP712 specific structure for stamp & input data to avoid common structural errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: passportxyz/eas-proxy#32