Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify paywall entities #923

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Simplify paywall entities #923

merged 2 commits into from
Nov 24, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Nov 24, 2024

  • PaywallView is the paywall content
  • PaywallModifier attaches paywall with optional confirmation
  • PurchaseRequiredButton presents paywall explicitly
  • PaywallReason is the compound input

Refactoring:

  • PurchaseRequiredButton takes a custom view
  • PurchaseAlertModifier was merged into PaywallModifier
  • PurchaseButtonModifier was merged into PurchaseRequiredButton
  • Modal options were packed into a single struct

Confirmation alert presented on:

  • Connect to ineligible profile (AppCoordinator)
  • Save ineligible profile (ProfileCoordinator)

- PaywallView is the paywall content
- PaywallModifier attaches paywall with optional confirmation
- PurchaseRequiredButton presents the paywall explicitly

Refactoring:

- PurchaseRequiredButton takes a custom view
- PurchaseAlertModifier was merged into PaywallModifier
- PurchaseButtonModifier was merged into PurchaseRequiredButton
- Modal options were packed into a single struct
@keeshux keeshux self-assigned this Nov 24, 2024
@keeshux keeshux added bug Something isn't working refactoring Improves software architecture labels Nov 24, 2024
@keeshux keeshux added this to the 3.0.0 / 7. Release milestone Nov 24, 2024
@keeshux keeshux merged commit 2aa91ee into master Nov 24, 2024
@keeshux keeshux deleted the bugfix/uniform-paywall-modifiers branch November 24, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring Improves software architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant