Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and test ProductManager #437

Merged
merged 25 commits into from
Dec 20, 2023
Merged

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Dec 20, 2023

Carefully drop the StoreKit and Kvitto dependencies for ProductManager to be testable.

Rebuild test target completely to start writing meaningful tests in general.

@keeshux keeshux added the refactoring Improves software architecture label Dec 20, 2023
@keeshux keeshux added this to the Unit tests milestone Dec 20, 2023
@keeshux keeshux self-assigned this Dec 20, 2023
@keeshux keeshux marked this pull request as draft December 20, 2023 07:50
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from 66530bd to 56d1827 Compare December 20, 2023 08:00
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from 56d1827 to 8ad7a9d Compare December 20, 2023 08:01
@keeshux keeshux marked this pull request as ready for review December 20, 2023 08:03
@keeshux keeshux marked this pull request as draft December 20, 2023 08:11
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from 8ad7a9d to e57e76e Compare December 20, 2023 08:13
@keeshux keeshux removed this from the Unit tests milestone Dec 20, 2023
@keeshux keeshux marked this pull request as ready for review December 20, 2023 10:38
Fix behavior of isEligible on platform products.
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from 7232b38 to 9956329 Compare December 20, 2023 15:47
@keeshux keeshux marked this pull request as draft December 20, 2023 15:47
@keeshux keeshux marked this pull request as ready for review December 20, 2023 15:49
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from c9ec6f8 to 0c75c6b Compare December 20, 2023 15:49
@keeshux keeshux marked this pull request as draft December 20, 2023 15:49
Test library with 'swift test'.
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from 0c75c6b to b0795dd Compare December 20, 2023 17:30
@keeshux keeshux added this to the Unit test frontend milestone Dec 20, 2023
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from 510e756 to e0a0bcc Compare December 20, 2023 18:00
@keeshux keeshux marked this pull request as ready for review December 20, 2023 18:09
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from c19b172 to c1297d0 Compare December 20, 2023 18:21
@keeshux keeshux force-pushed the refactoring/test-product-manager branch from c1297d0 to b2b827d Compare December 20, 2023 19:32
@keeshux keeshux merged commit a0da930 into master Dec 20, 2023
@keeshux keeshux deleted the refactoring/test-product-manager branch December 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improves software architecture
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant