Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added composer installer signature check according to official composer docs #91

Merged

Conversation

DerDummePunkt
Copy link
Contributor

You can never be too careful.
This PR replaces the portion of the Dockefiles RUN statement, which deals with installing composer, with a more secure version, which also checks the SHA384 checksum of the downloaded installer against a SHA384 checksum obtained from the official git repository of the composer project.

The intention is to provide one additional layer of secruity against man-in-the-middle / spoofing attacks.
It is possible that someone might capture or redirect https://getcomposer.org/installer during docker build and replace the composer install file with a malicous version, which, in turn, would install malicous composer packages.
I would consider it to be less likely that someone might capture both https://getcomposer.org/installer and https://composer.github.io/installer.sig at the same time, thus increasing security.

added composer installer signature check according to official composer docs : https://getcomposer.org/doc/faqs/how-to-install-composer-programmatically.md

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2018

CLA assistant check
All committers have signed the CLA.

@dlen dlen self-assigned this Mar 10, 2018
@dlen
Copy link
Member

dlen commented Mar 10, 2018

Hi @DerDummePunkt thanks for your contribution!! You are completely right and your PR looks just fine all tests are green :)

@dlen dlen merged commit 91598d8 into passbolt:develop Mar 10, 2018
@DerDummePunkt DerDummePunkt deleted the feature/composer_signature_check branch March 10, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants