Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BSR) chore(ios): fix CLI by using older DevBox version #7295

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

bebstein-pass
Copy link
Contributor

Partially Revert "(BSR) chore(deps): update tools (#7200)"

This reverts commit 332e355.

For some reasons, with the newer version when running the following command

yarn ios:testing

It outputs the following error

yarn run v1.22.22
$ yarn ios --scheme PassCulture-Testing
$ ./scripts/check_xcode_version.sh
warning: unhandled Target key DefaultVariant
warning: unhandled Target key SupportedTargets
warning: unhandled Target key VersionMap
warning: unhandled Target key Variants
warning: unhandled Target key DebuggerOptions
warning: unhandled Product key iOSSupportVersion
warning: unhandled Target key DefaultVariant
warning: unhandled Target key SupportedTargets
warning: unhandled Target key VersionMap
warning: unhandled Target key Variants
warning: unhandled Target key DebuggerOptions
warning: unhandled Product key iOSSupportVersion
warning: unhandled Target key DefaultVariant
warning: unhandled Target key SupportedTargets
warning: unhandled Target key VersionMap
warning: unhandled Target key Variants
warning: unhandled Target key DebuggerOptions
warning: unhandled Product key iOSSupportVersion
error: tool 'xcodebuild' not found
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-XXXXX

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

@bebstein-pass
Copy link
Contributor Author

Probably introduced by jetify-com/devbox#2259

@bebstein-pass bebstein-pass changed the title (BSR) chore(ios): fix CLI (BSR) chore(ios): fix CLI by using older DevBox version Nov 27, 2024
This reverts commit 332e355.

For some reasons, with the newer version when running the following command

```sh
yarn ios:testing
```

It outputs the following error

```txt

yarn run v1.22.22
$ yarn ios --scheme PassCulture-Testing
$ ./scripts/check_xcode_version.sh
warning: unhandled Target key DefaultVariant
warning: unhandled Target key SupportedTargets
warning: unhandled Target key VersionMap
warning: unhandled Target key Variants
warning: unhandled Target key DebuggerOptions
warning: unhandled Product key iOSSupportVersion
warning: unhandled Target key DefaultVariant
warning: unhandled Target key SupportedTargets
warning: unhandled Target key VersionMap
warning: unhandled Target key Variants
warning: unhandled Target key DebuggerOptions
warning: unhandled Product key iOSSupportVersion
warning: unhandled Target key DefaultVariant
warning: unhandled Target key SupportedTargets
warning: unhandled Target key VersionMap
warning: unhandled Target key Variants
warning: unhandled Target key DebuggerOptions
warning: unhandled Product key iOSSupportVersion
error: tool 'xcodebuild' not found
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
Copy link

sonarcloud bot commented Nov 28, 2024

Copy link

sonarcloud bot commented Nov 28, 2024

@bebstein-pass bebstein-pass merged commit 4f2d9ad into master Nov 28, 2024
50 checks passed
@bebstein-pass bebstein-pass deleted the fix-ios-cli branch November 28, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants