-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-32644) feat(deeplinks): add ThematicSearch pages #7294
Conversation
b521380
to
c2187bf
Compare
@@ -132,6 +134,13 @@ export const SCREENS_CONFIG: { | |||
Profile: {}, | |||
SignupForm: {}, | |||
Stepper: {}, | |||
ThematicSearch: { | |||
thematicSearchCategories: { | |||
type: 'thematicSearchCategories', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La ThematicSearch
elle attend des offerCategories en param, également dans la ThematicSearchBar
. Tu as pu tester le fonctionnement des deeplinks ?
c2187bf
to
c13d63c
Compare
This reverts commit 329f24b1765fe413ec555fbb1c08bdf9fe39d5ea.
c13d63c
to
5516f42
Compare
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Bravo pour ton travail 🦾🚀 Je vois juste un comportement que je voudrais confirmer avec toi :
Est-ce que tu reproduis ? Est ce un comportement connu / attendu ? |
C'est déjà le comportement de la SearchResults. Je remonte à Clément car ce serait un chantier général si on voulait modifier ce comportement :) |
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32644
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
Enregistrement.de.l.ecran.2024-11-28.a.13.57.44.mov
Best Practices
Click to expand
!
when you know that the value can’t benull
orundefined
).Test specific:
user
tofireEvent
.