Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32644) feat(deeplinks): add ThematicSearch pages #7294

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

nmajorfrances-pass
Copy link
Contributor

@nmajorfrances-pass nmajorfrances-pass commented Nov 27, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32644

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion
  • I am aware of all the best practices and respected them.

Screenshots

Enregistrement.de.l.ecran.2024-11-28.a.13.57.44.mov

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

@@ -132,6 +134,13 @@ export const SCREENS_CONFIG: {
Profile: {},
SignupForm: {},
Stepper: {},
ThematicSearch: {
thematicSearchCategories: {
type: 'thematicSearchCategories',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La ThematicSearch elle attend des offerCategories en param, également dans la ThematicSearchBar. Tu as pu tester le fonctionnement des deeplinks ?

Copy link

sonarcloud bot commented Nov 28, 2024

Copy link

sonarcloud bot commented Nov 28, 2024

@imouandjolobe-pass
Copy link
Contributor

Bravo pour ton travail 🦾🚀

Je vois juste un comportement que je voudrais confirmer avec toi :

  • Je clique sur le deeplink, depuis la TS Livres, je clique sur une offre, je clique sur la flèche go back => j'atterris sur la page d'accueil au lieu de revenir sur la TS Livres

Est-ce que tu reproduis ? Est ce un comportement connu / attendu ?

@nmajorfrances-pass
Copy link
Contributor Author

C'est déjà le comportement de la SearchResults. Je remonte à Clément car ce serait un chantier général si on voulait modifier ce comportement :)

@nmajorfrances-pass nmajorfrances-pass merged commit a23dbf8 into master Nov 28, 2024
53 checks passed
@nmajorfrances-pass nmajorfrances-pass deleted the PC-32644-deeplinksThematicSearch branch November 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants