Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33299) fix(thematicSearch): limit usage of transformOfferHits #7292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tprache-pass
Copy link
Contributor

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33299

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident [on Notion][2]

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" [on Notion][1]
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS Simulator Screenshot - iPhone 13 mini - 2024-11-27 at 16 43 57 Simulator Screenshot - iPhone 13 mini - 2024-11-27 at 16 44 09

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

@tprache-pass tprache-pass force-pushed the pc-33299/fix-thematicsearch-prices branch from 2398a47 to f276a9c Compare November 27, 2024 16:17
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant