(PC-33187) feat(venueMap): apply filter when pressing checkbox in venue type modal filter #7291
+257
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Le test qui casse ne dépend pas de ma PR (déjà présent sur master) |
|
Je vais envoyer un commit en +, il y a un comportement que je n'avais pas vu |
yleclercq-pass
approved these changes
Nov 28, 2024
…ue type modal filter
… previous filter is all venue type group
clesausse-pass
force-pushed
the
PC-33187
branch
from
df2db9e
to
d0fff30
Compare
|
Comment on lines
36
to
45
| const toggleFilters = (isChecked: boolean, filters: VenueTypeCodeKey[]) => { | ||
| if (isChecked) { | ||
| if (hasAllFilters) { | ||
| // Only the current selection is filtered | ||
| setVenuesFilters(filters) | ||
| return | ||
| } | ||
| addVenuesFilters(filters) | ||
| return | ||
| } |
There was a problem hiding this comment.
Petite question tu n'as pas besoin du toggleMacroFilters dans le hook ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33187
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Best Practices
Click to expand
!when you know that the value can’t benullorundefined).Test specific:
usertofireEvent.