Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33100) feat(venueMap): add filters modal #7280

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

clesausse-pass
Copy link
Contributor

@clesausse-pass clesausse-pass commented Nov 26, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33100

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

iOS :

Enregistrement.de.l.ecran.2024-11-26.a.15.04.24.mov

Android :

Enregistrement.de.l.ecran.2024-11-26.a.15.16.07.mov

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

@@ -32,6 +33,12 @@ const RootStackNavigator = withWebWrapper(
initialRouteName={initialRouteName}
screenOptions={ROOT_NAVIGATOR_SCREEN_OPTIONS}>
{RootScreens}
<RootStack.Group screenOptions={{ presentation: 'modal' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne suis pas sûr que tu aies besoin d'un groupe, tu peux directement mettre presentation:modal dans les options du Screen il me semble.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et par miracle ça fixe les tests de RootNavigator ^^ merci

Copy link

sonarcloud bot commented Nov 26, 2024

Copy link

sonarcloud bot commented Nov 26, 2024

@clesausse-pass clesausse-pass merged commit da7c9b2 into master Nov 26, 2024
62 checks passed
@clesausse-pass clesausse-pass deleted the PC-33100 branch November 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants