-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-33100) feat(venueMap): add filters modal #7280
Conversation
@@ -32,6 +33,12 @@ const RootStackNavigator = withWebWrapper( | |||
initialRouteName={initialRouteName} | |||
screenOptions={ROOT_NAVIGATOR_SCREEN_OPTIONS}> | |||
{RootScreens} | |||
<RootStack.Group screenOptions={{ presentation: 'modal' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne suis pas sûr que tu aies besoin d'un groupe, tu peux directement mettre presentation:modal
dans les options du Screen il me semble.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Et par miracle ça fixe les tests de RootNavigator ^^ merci
src/features/venueMap/components/VenueMapFiltersList/VenueMapFiltersList.native.test.tsx
Show resolved
Hide resolved
src/features/venueMap/components/VenueMapTypeFilter/VenueMapTypeFilter.native.test.tsx
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33100
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
delete if no UI change
iOS :
Enregistrement.de.l.ecran.2024-11-26.a.15.04.24.mov
Android :
Enregistrement.de.l.ecran.2024-11-26.a.15.16.07.mov
Best Practices
Click to expand
!
when you know that the value can’t benull
orundefined
).Test specific:
user
tofireEvent
.