Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33007) chore(web): remove service worker #7274

Merged
merged 2 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 0 additions & 130 deletions .github/workflows/dev_on_dispatch_service_worker_test.yml

This file was deleted.

2 changes: 0 additions & 2 deletions doc/development/general-info-web.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ There are certain number of optimizations/improvements and things that were done

MUST HAVE:

- Remove service workers (caused cache update issues) and manifest if we decide to not use PWA (because it requires maintenance).
- Test older browsers
- If needed, increase compatibility with `@vitejs/plugin-legacy` (you will need to install `terser` for the plugin to work)

Expand All @@ -142,7 +141,6 @@ COULD HAVE:
- Using vite's chunking technology (or any other chunking technology) to reduce the initial loading time of the web app
- Chunk protection (check there isn't any bundle issues and protect against future issues)
- Depending on the compatibility with older browsers, update `src/web/SupportedBrowsersGate.web.test.tsx` and `package.json.browserList`
- PWA (it seems that vite generates a manifest but we should make sure the service worker is functioning)

COULD BE NICE TO HAVE:

Expand Down
15 changes: 1 addition & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"test:lint": "eslint . --ext .js,.ts,.tsx,.mjs --cache",
"test:perf": "NODE_ENV=performance NODE_OPTIONS='--no-experimental-fetch' TEST_RUNNER_ARGS='--runInBand --testMatch \"<rootDir>/**/*.perf.test.tsx\"' yarn reassure",
"test:perf:update": "yarn test:perf --baseline",
"test:sw": "node scripts/service-worker-test.mjs",
"test:storybook:accessibility": "TZ=UTC axe-storybook --storybook-address http://localhost:6006",
"test:types": "tsc",
"test:types:noUncheckedIndexedAccess": "grep --recursive --line-number ./src --regexp '// @ts-expect-error: because of noUncheckedIndexedAccess' | awk -F: '{print $1\":\"$2}' | sort",
Expand Down Expand Up @@ -349,19 +348,7 @@
"typescript": "5.0.4",
"url-loader": "^4.1.1",
"vite": "^5.3.1",
"vite-plugin-html": "^3.2.2",
"workbox-background-sync": "^6.1.5",
"workbox-broadcast-update": "^6.1.5",
"workbox-cacheable-response": "^6.1.5",
"workbox-core": "^6.1.5",
"workbox-expiration": "^6.1.5",
"workbox-google-analytics": "^6.1.5",
"workbox-navigation-preload": "^7.1.0",
"workbox-precaching": "^6.1.5",
"workbox-range-requests": "^6.1.5",
"workbox-routing": "^6.1.5",
"workbox-strategies": "^6.1.5",
"workbox-streams": "^6.1.5"
"vite-plugin-html": "^3.2.2"
},
"resolutions": {
"@sentry/cli": "^2.33.1",
Expand Down
127 changes: 0 additions & 127 deletions scripts/service-worker-test.mjs

This file was deleted.

Loading