-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-32700) feat(NC): add New Caledonian phone number check in SetPhoneNumber #7266
base: master
Are you sure you want to change the base?
Conversation
d561e1e
to
5f5d09c
Compare
bec9ff2
to
c6d7082
Compare
Quality Gate failedFailed conditions |
return false | ||
} | ||
export function isPhoneNumberValid(number: string, country: string) { | ||
const phoneNumber = parsePhoneNumberFromString(number, country as CountryCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le "as" on essaye d'eviter au maximun, si tu peux pas faire autrement, il faut que t'expliques pourquoi avec un commentaire
c46261a
to
2ac17f1
Compare
2ac17f1
to
6a58f8b
Compare
Quality Gate passedIssues Measures |
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32700
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
delete if no UI change
Best Practices
Click to expand
!
when you know that the value can’t benull
orundefined
).Test specific:
user
tofireEvent
.