(PC-32111) feat(XPCine): add a button anchor to access to screenings #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecunff-pass
force-pushed
the
PC-32111
branch
8 times, most recently
from
35ab359
to
cd9bed1
Compare
imouandjolobe-pass
force-pushed
the
PC-32111
branch
from
224efa4
to
c50829c
Compare
xlecunff-pass
force-pushed
the
PC-32111
branch
4 times, most recently
from
3a30f43
to
36826f1
Compare
xlecunff-pass
force-pushed
the
PC-32111
branch
from
36826f1
to
c63348c
Compare
|
|
nmajorfrances-pass
approved these changes
Nov 28, 2024
|
|
||
| await userEvent.press(button) | ||
|
|
||
| expect(useScrollToAnchorSpy).toHaveBeenCalledWith() |
There was a problem hiding this comment.
pourquoi le 'with' ?
There was a problem hiding this comment.
car on ne peut pas appeler toHaveBeenCalled() sans avoir d'erreur à cause de notre linter, le but est simplement de voir si la fonction a été appelée dans ce test sans se soucier des paramètres passée à la fonction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32111
Checklist
I have:
PC-32111-android.mov