(PC-32770) fix(highlightLinks): fix links highlighting #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Comparison ReportSignificant Changes To Render DurationThere are no entries Meaningless Changes To Render DurationShow entries
Show details
Changes To Render CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
tconte-pass
force-pushed
the
pc-32770-fix-links-highlighting
branch
from
589efbf
to
a4312e1
Compare
The purpose is to exclude cases where a dot is not followed by a space like 'final word.Then'. We'll continue to make the mistake on inclusive writing for now, like 'revigorant.e'.
tconte-pass
force-pushed
the
pc-32770-fix-links-highlighting
branch
from
a4312e1
to
aaa6721
Compare
|
|
nmajorfrances-pass
approved these changes
Nov 6, 2024
| @@ -11,6 +11,10 @@ const description1WithoutUrl = `PRESSE / ILS EN PARLENT ! | |||
| « Hilarant » Vanity Fair | |||
| Voir plus de critiques en suivant le lien suivant :` | |||
|
|
|||
| const descriptionWithoutSpaceAfterDot = `Lorem ipsum dolor sit amet consectetur adipiscing elit.Sed non risus.` | |||
|
|
|||
| const descriptionWitUppercaseLink = `Lorem ipsum dolor sit amet consectetur adipiscing Elit.sed non risus.` | |||
There was a problem hiding this comment.
descriptionWithUppercaseLink ?
There was a problem hiding this comment.
Un lien qui commence par une majuscule ... Tu aurais nommé ça comment ?
There was a problem hiding this comment.
ah oui mon comm est pas claire , je voulais dire qu'il manquait le 'H' de 'with' :)
| @@ -11,6 +11,10 @@ const description1WithoutUrl = `PRESSE / ILS EN PARLENT ! | |||
| « Hilarant » Vanity Fair | |||
| Voir plus de critiques en suivant le lien suivant :` | |||
|
|
|||
| const descriptionWithoutSpaceAfterDot = `Lorem ipsum dolor sit amet consectetur adipiscing elit.Sed non risus.` | |||
|
|
|||
| const descriptionWitUppercaseLink = `Lorem ipsum dolor sit amet consectetur adipiscing Elit.sed non risus.` | |||
There was a problem hiding this comment.
Je comprend pas où est le lien, peut être qu'un veritable exemple plutôt dque du Lorem ipsum serait plus parlant ?
There was a problem hiding this comment.
Elit.sed est considéré comme un lien
| @@ -177,7 +174,7 @@ describe('highlightLinks', () => { | |||
| ) | |||
|
|
|||
| expect(parsedDescription).toEqual([ | |||
| <ExternalLink key="external-link-0" url="http://www.penofchaos.com/warham/donjon.htm" />, | |||
| <ExternalLink key="external-link-0" url="www.penofchaos.com/warham/donjon.htm" />, | |||
There was a problem hiding this comment.
ce type de lien fonctionne ? (web, iOS, Android)
| @@ -7,20 +7,18 @@ type ParsedDescription = Array<string | React.ReactNode> | |||
|
|
|||
| const externalNavRegex = new RegExp( | |||
| /((^|\s)|https?:\/\/)[a-z]([-a-z0-9:%._+~#=]*[a-z0-9])?\.[a-z0-9]{1,6}([/?#]\S*)?(\s|$)/, | |||
There was a problem hiding this comment.
il me semble que coté pro, iels ont changés la façon de gérer les liens dans les descriptions
est-on encore aligné ?
There was a problem hiding this comment.
Pourquoi est-ce qu'on doit être alignés entre leur façon de récupérer/afficher une URL et la nôtre ?
There was a problem hiding this comment.
si je suis un pro, que je prends le temps d'écrire une description qui est super bien, d'ajouter des liens où il faut et que :
- coté jeunes, des liens s'affichent à des endroits qui n'y étaient pas coté pro
- coté jeunes, des liens ne s'affichent pas à des endroits qui y étaient coté pro
je serais mécontent, et je dirais que c'est buggué
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32770
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
delete if no UI change