(PC-32596) feat(accessibility): remove AccessibilityRole Dialog in Ap…

[lbeneston-pass]

…pModal

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32596

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

• Made sure my feature is working on web.
• Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
• Written unit tests native (and web when implementation is different) for my feature.
• Added a screenshot for UI tickets or deleted the screenshot section if no UI change
• If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform	Mockup/Before	After
iOS
Android
Phone - Chrome
Desktop - Chrome

[github-actions]

Performance Comparison Report

• Current: HEAD (0ef4b27)
• Baseline: master (f09c87a)

Significant Changes To Render Duration

Name	Render Duration	Render Count
Performance test for Bookings page	99.4 ms → 104.8 ms (+5.4 ms, +5.4%) 🔴	11 → 11

Show details

Name	Render Duration	Render Count
Performance test for Bookings page	Baseline Mean: 99.4 ms Stdev: 3.3 ms (3.3%) Runs: 106 103 101 101 98 98 98 97 97 95 Current Mean: 104.8 ms Stdev: 5.0 ms (4.8%) Runs: 114 109 107 106 106 106 104 100 98 98	Baseline Mean: 11 Stdev: 0 (0.0%) Runs: 11 11 11 11 11 11 11 11 11 11 Current Mean: 11 Stdev: 0 (0.0%) Runs: 11 11 11 11 11 11 11 11 11 11

Meaningless Changes To Render Duration

Show entries

Name	Render Duration	Render Count
Performance test for EndedBookings page	33.0 ms → 35.2 ms (+2.2 ms, +6.7%)	7 → 7
Performance test for Favorites page	64.0 ms → 65.9 ms (+1.9 ms, +3.0%)	6 → 6
Performance test for Offer page	72.3 ms → 73.8 ms (+1.5 ms, +2.1%)	2 → 2
Search Results - Performance test for Search Results page	14.6 ms → 14.8 ms (+0.2 ms, +1.4%)	5 → 5
Performance test for Venue page	2.8 ms → 2.6 ms (-0.2 ms, -7.1%)	2 → 2
Performance test for Profile page	6.3 ms → 6.1 ms (-0.2 ms, -3.2%)	5 → 5
Search Landing Page - Performance test for Search Landing page	14.5 ms → 13.9 ms (-0.6 ms, -4.1%)	5 → 5

Show details

Name	Render Duration	Render Count
Performance test for EndedBookings page	Baseline Mean: 33.0 ms Stdev: 1.7 ms (5.2%) Runs: 36 35 34 33 33 33 32 32 32 30 Current Mean: 35.2 ms Stdev: 1.3 ms (3.7%) Runs: 37 36 36 36 36 35 35 35 33 33	Baseline Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7 Current Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Favorites page	Baseline Mean: 64.0 ms Stdev: 3.3 ms (5.1%) Runs: 69 66 66 66 65 64 63 62 62 57 Current Mean: 65.9 ms Stdev: 4.4 ms (6.7%) Runs: 72 70 69 68 67 67 65 62 61 58	Baseline Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6 Current Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Offer page	Baseline Mean: 72.3 ms Stdev: 3.0 ms (4.2%) Runs: 76 76 74 74 74 73 70 69 69 68 Current Mean: 73.8 ms Stdev: 3.6 ms (4.9%) Runs: 82 75 75 75 74 73 73 72 71 68	Baseline Mean: 2 Stdev: 0 (0.0%) Runs: 2 2 2 2 2 2 2 2 2 2 Current Mean: 2 Stdev: 0 (0.0%) Runs: 2 2 2 2 2 2 2 2 2 2
Search Results - Performance test for Search Results page	Baseline Mean: 14.6 ms Stdev: 1.6 ms (11.3%) Runs: 16 16 16 16 15 15 14 14 13 11 Current Mean: 14.8 ms Stdev: 1.3 ms (8.9%) Runs: 18 15 15 15 15 15 14 14 14 13	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Venue page	Baseline Mean: 2.8 ms Stdev: 0.9 ms (32.8%) Runs: 4 4 4 3 3 2 2 2 2 2 Current Mean: 2.6 ms Stdev: 0.7 ms (26.9%) Runs: 4 3 3 3 3 2 2 2 2 2	Baseline Mean: 2 Stdev: 0 (0.0%) Runs: 2 2 2 2 2 2 2 2 2 2 Current Mean: 2 Stdev: 0 (0.0%) Runs: 2 2 2 2 2 2 2 2 2 2
Performance test for Profile page	Baseline Mean: 6.3 ms Stdev: 0.8 ms (13.1%) Runs: 8 7 7 6 6 6 6 6 6 5 Current Mean: 6.1 ms Stdev: 0.9 ms (14.4%) Runs: 8 7 6 6 6 6 6 6 5 5	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Search Landing Page - Performance test for Search Landing page	Baseline Mean: 14.5 ms Stdev: 1.8 ms (12.3%) Runs: 18 16 16 15 14 14 14 13 13 12 Current Mean: 13.9 ms Stdev: 1.7 ms (12.4%) Runs: 15 15 15 15 15 15 14 13 12 10	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against a3cff11

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud