Skip to content

Commit

Permalink
(PC-33007) chore(web): remove service worker
Browse files Browse the repository at this point in the history
  • Loading branch information
cgerrard-pass committed Nov 25, 2024
1 parent b657b4e commit 59816d8
Show file tree
Hide file tree
Showing 10 changed files with 41 additions and 884 deletions.
130 changes: 0 additions & 130 deletions .github/workflows/dev_on_dispatch_service_worker_test.yml

This file was deleted.

2 changes: 0 additions & 2 deletions doc/development/general-info-web.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ There are certain number of optimizations/improvements and things that were done

MUST HAVE:

- Remove service workers (caused cache update issues) and manifest if we decide to not use PWA (because it requires maintenance).
- Test older browsers
- If needed, increase compatibility with `@vitejs/plugin-legacy` (you will need to install `terser` for the plugin to work)

Expand All @@ -142,7 +141,6 @@ COULD HAVE:
- Using vite's chunking technology (or any other chunking technology) to reduce the initial loading time of the web app
- Chunk protection (check there isn't any bundle issues and protect against future issues)
- Depending on the compatibility with older browsers, update `src/web/SupportedBrowsersGate.web.test.tsx` and `package.json.browserList`
- PWA (it seems that vite generates a manifest but we should make sure the service worker is functioning)

COULD BE NICE TO HAVE:

Expand Down
15 changes: 1 addition & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"test:lint": "eslint . --ext .js,.ts,.tsx,.mjs --cache",
"test:perf": "NODE_ENV=performance NODE_OPTIONS='--no-experimental-fetch' TEST_RUNNER_ARGS='--runInBand --testMatch \"<rootDir>/**/*.perf.test.tsx\"' yarn reassure",
"test:perf:update": "yarn test:perf --baseline",
"test:sw": "node scripts/service-worker-test.mjs",
"test:storybook:accessibility": "TZ=UTC axe-storybook --storybook-address http://localhost:6006",
"test:types": "tsc",
"test:types:noUncheckedIndexedAccess": "grep --recursive --line-number ./src --regexp '// @ts-expect-error: because of noUncheckedIndexedAccess' | awk -F: '{print $1\":\"$2}' | sort",
Expand Down Expand Up @@ -349,19 +348,7 @@
"typescript": "5.0.4",
"url-loader": "^4.1.1",
"vite": "^5.3.1",
"vite-plugin-html": "^3.2.2",
"workbox-background-sync": "^6.1.5",
"workbox-broadcast-update": "^6.1.5",
"workbox-cacheable-response": "^6.1.5",
"workbox-core": "^6.1.5",
"workbox-expiration": "^6.1.5",
"workbox-google-analytics": "^6.1.5",
"workbox-navigation-preload": "^7.1.0",
"workbox-precaching": "^6.1.5",
"workbox-range-requests": "^6.1.5",
"workbox-routing": "^6.1.5",
"workbox-strategies": "^6.1.5",
"workbox-streams": "^6.1.5"
"vite-plugin-html": "^3.2.2"
},
"resolutions": {
"@sentry/cli": "^2.33.1",
Expand Down
1 change: 0 additions & 1 deletion public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@
media="(device-width: 1024px) and (device-height: 1366px) and (-webkit-device-pixel-ratio: 2)"
rel="apple-touch-startup-image"
/>
<link rel="manifest" href="<%- PUBLIC_URL %>/manifest.json" />
<style>
@import url('<%- PUBLIC_URL %>/font-faces.css');
@font-face {
Expand Down
127 changes: 0 additions & 127 deletions scripts/service-worker-test.mjs

This file was deleted.

Loading

0 comments on commit 59816d8

Please sign in to comment.