Changes for compatibility with upcoming export format #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CdeTerra
approved these changes
Apr 1, 2022
| @@ -1263,11 +1249,12 @@ def _target( | |||
| self._last_target[channel] = tf | |||
| self._add_to_schedule(channel, _TimeSlot("target", ti, tf, qubits_set)) | |||
|
|
|||
| def _delay(self, duration: int, channel: str) -> None: | |||
| def _delay(self, duration: Union[int, Parametrized], channel: str) -> None: | |||
There was a problem hiding this comment.
It seems surprising to me to allow parametrized values here, since the function not decorated with _store.
There was a problem hiding this comment.
_store actually does not block the call to the decorated function, it simply stores it. So, in fact, the parametrized values can reach _delay().
|
Thank you for the review @CdeTerra ! |
Merged
HGSilveri
added a commit
that referenced
this pull request
May 13, 2022
Main changes: - 3921795 Remove string variables (#365) - b23ff22 Splitting `pulser` into `pulser-core` and `pulser-simulation`. (#362) - 4f684f3 Address qubits with indices (#356) - f2ee5e2 Make evaluation times uniform including final time (#330) - c34dffb Changes for compatibility with upcoming export format (#353) - 3ac1f66 Sequence sampler (#345)
HGSilveri
added a commit
that referenced
this pull request
May 13, 2022
Main changes: - 3921795 Remove string variables (#365) - b23ff22 Splitting `pulser` into `pulser-core` and `pulser-simulation`. (#362) - 4f684f3 Address qubits with indices (#356) - f2ee5e2 Make evaluation times uniform including final time (#330) - c34dffb Changes for compatibility with upcoming export format (#353) - 3ac1f66 Sequence sampler (#345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpSupportVariable.__len__()to allow for applications of numpy ufuncs without unpacking