Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Allow file reading in the middle of request body #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cww0614
Copy link

@cww0614 cww0614 commented Sep 20, 2020

IMHO the regular expression to match the pattern is strict enough that in few cases will this collide with real body contents, and this enables more intuitive body construction, especially when uploading files with multipart/form-data. Futhermore, this should also allow variable substitution in file paths.

@arichiardi
Copy link

LGTM! And nice 😄

@arichiardi
Copy link

I tried this in my branch but it does not seem to work. The error I see is a cryptic Args out of range: 62, 66. The regex does find the file and tries to replace things. It is basically replace-regexp-in-string that seems to fail.

@cww0614
Copy link
Author

cww0614 commented Feb 18, 2021

I tried this in my branch but it does not seem to work. The error I see is a cryptic Args out of range: 62, 66. The regex does find the file and tries to replace things. It is basically replace-regexp-in-string that seems to fail.

Can you give an example that will cause this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants