Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to running action in JS instead of Docker #135

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

haldunanil
Copy link
Contributor

@haldunanil haldunanil commented Dec 18, 2020

This PR fixes #125. Specifically, it:

  • Transitions the action from a Docker-based one to a JavaScript-based one, removing all Docker related files
  • Uses the @vercel/ncc library to precompile the source code, including all node_modules, into a dist/index.js file, meaning no install/compile necessary when running the action
  • Substantially reduces time for a single run (from approx ~2 minutes/run to ~10 seconds/run)

NOTE: This PR avoids making any changes beyond what is necessary to make the action work in a JS environment. As a result, new features like action inputs are not included.

@haldunanil
Copy link
Contributor Author

@pascalgn this is ready for review :)

@pascalgn pascalgn merged commit 7e53ea3 into pascalgn:master Dec 21, 2020
@pascalgn
Copy link
Owner

Really nice PR, thanks! It's merged now and released as v0.13.0 👍

@haldunanil
Copy link
Contributor Author

Yay, that's awesome, thanks @pascalgn ! :)

@haldunanil haldunanil deleted the transition-to-js branch December 21, 2020 16:58
This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Why isn't this action a javascript action
2 participants